perf: machine string #1994
perf: machine string #1994
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1994 +/- ##
==========================================
+ Coverage 46.63% 46.82% +0.18%
==========================================
Files 492 492
Lines 69624 69767 +143
==========================================
+ Hits 32472 32670 +198
+ Misses 34445 34388 -57
- Partials 2707 2709 +2 ☔ View full report in Codecov by Sentry. |
petar-dambovaliev
requested review from
thehowl
and removed request for
thehowl
|
do you have some benchmarks to share? |
Benchmark pushed. current branch master branch |
petar-dambovaliev
requested review from
jaekwon,
piux2,
thehowl and
moul
as code owners
petar-dambovaliev
requested review from
zivkovicmilos,
ajnavarro and
thehowl
and removed request for
thehowl
|
How long does it take to print the machine string if it exceeds memory allocation due to an infinitely recursing function? |
That issue is being fixed in another PR |
| Op: %v | ||
| Values: (len: %d) | ||
| %s | ||
| Exprs: |
There was a problem hiding this comment.
Where does the new code print these headers? I can see one for Realm for not for the others
Make the
Stringmethod on theMachinestruct faster by preallocating a string builder.issue